Update SharpPcap.csproj #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove LGPL3.0 license from Nuget. Update version to 6.3.0. This should(?) create a new Nuget release as well, with the new license.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #507 +/- ##
==========================================
+ Coverage 82.21% 82.25% +0.03%
==========================================
Files 51 51
Lines 2823 2823
Branches 312 312
==========================================
+ Hits 2321 2322 +1
+ Misses 381 379 -2
- Partials 121 122 +1 ☔ View full report in Codecov by Sentry. |
kayoub5
approved these changes
Feb 23, 2024
|
@chmorgan could you double check the api key for nuget, CI is failing to upload a new version |
|
Yep, I’ll check in this afternoon. Maybe it’s expired and I missed the
notice. Afaict there wasn’t a way to give you access to the account so you
could admin.
…On Sun, Feb 25, 2024 at 10:25 AM Ayoub Kaanich ***@***.***> wrote:
@chmorgan <https://github.com/chmorgan> could you double check the api
key for nuget, CI is failing to upload a new version
—
Reply to this email directly, view it on GitHub
<#507 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJH4AGRPJNFJLDS5NQUH3DYVNJWHAVCNFSM6AAAAABDWPFOBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRSHE3TGOJVGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@kayoub5 updated secrets with new keys for all three repositories. Can you retry the build/package push? |
|
The package was updated in the Nuget feed. Thanks a lot for the quick turnaround time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove LGPL3.0 license from Nuget. Update version to 6.3.0.
This should(?) create a new Nuget release as well, with the new license.